feat: Update FastembedRanker to auto call warm_up on first run#2834
Merged
Conversation
bogdankostic
requested review from
julian-risch
and removed request for
a team
github-actions
Bot
added
the
type:documentation
julian-risch
requested changes
Feb 13, 2026
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
Looks quite good to me already. Let's also remove the explicit warm_up calls from the integration tests.
Could you please also open an issue or a directly a PR for removing warm_up from the code examples in the docs pages?
Member
|
There already is an issue for tracking updating the integration pages: #2751 |
Contributor
Author
|
I removed the explicit warm_up calls from the integration tests and adapted the documentation in this PR: deepset-ai/haystack#10586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
FastembedRankerdoesn't automaticallywarm_upon first run #2833Proposed Changes:
warm_upand don't modify Documents in place #2678,FastembedRanker'srunmethod is updated to automatically callwarm_upon first callwarm_upcall in docstrings of all FastEmbed componentsHow did you test it?
I added unit tests for all FastEmbed components to test if
warm_upis called on the first run.Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.